Skip to content
Snippets Groups Projects
Commit 017496af authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Georgi Djakov
Browse files

interconnect: fix memory trashing in of_count_icc_providers()


of_count_icc_providers() function uses for_each_available_child_of_node()
helper to recursively check all the available nodes. This helper already
properly handles child nodes' reference count, so there is no need to do
it explicitly. Remove the excessive call to of_node_put(). This fixes
memory trashing when CONFIG_OF_DYNAMIC is enabled (for example
arm/multi_v7_defconfig).

Fixes: b1d681d8 ("interconnect: Add sync state support")
Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20201119103746.32564-1-m.szyprowski@samsung.com


Signed-off-by: default avatarGeorgi Djakov <georgi.djakov@linaro.org>
parent 7ab1e911
No related branches found
No related tags found
No related merge requests found
......@@ -1083,7 +1083,6 @@ static int of_count_icc_providers(struct device_node *np)
count++;
count += of_count_icc_providers(child);
}
of_node_put(np);
return count;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment